Conversation
Owner
alexlib
commented
Mar 12, 2026
- due to failure on Windows without any warning for Read-only folders
- added Python checks and warnings and errors in the terminal instead of crash
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds preflight checks to ensure output directories are writable (especially on Windows), and updates tests to cover the new behavior so write failures produce actionable errors rather than silent/unclear failures.
Changes:
- Add output-path preparation + writable-directory probing helpers in
pyptv.ptv, and use them before writing targets/correspondence outputs. - Add GUI-side
res/directory creation/writability validation during initialization. - Update and expand tests to validate directory creation, probing, and error behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
pyptv/ptv.py |
Adds output path prep / write error helpers, probes target output dirs before writes, and routes write failures through actionable exceptions. |
pyptv/pyptv_gui.py |
Ensures res/ exists and is writable during GUI init to avoid later failures when writing outputs. |
tests/test_ptv_file_io.py |
Updates target-write tests to use real filesystem temp paths and adds coverage for new helper functions + preflight call. |
tests/test_gui_output_directory.py |
Adds tests for GUI res/ directory creation, warnings, and permission-error handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 task
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.