Skip to content

[WIP] [WIP] Address feedback on writable folders test implementation#106

Merged
alexlib merged 5 commits intomasterfrom
copilot/sub-pr-105
Mar 13, 2026
Merged

[WIP] [WIP] Address feedback on writable folders test implementation#106
alexlib merged 5 commits intomasterfrom
copilot/sub-pr-105

Conversation

Copy link
Contributor

Copilot AI commented Mar 13, 2026

  • Use directory.resolve(strict=False) instead of the conditional resolve() if exists else str() for a stable de-duplication key in _ensure_target_output_writable

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

alexlib and others added 3 commits March 12, 2026 23:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…solve(strict=False)

Co-authored-by: alexlib <747110+alexlib@users.noreply.github.com>
Base automatically changed from prepare_path to master March 13, 2026 21:30
@alexlib alexlib marked this pull request as ready for review March 13, 2026 21:31
Copilot AI review requested due to automatic review settings March 13, 2026 21:31
@alexlib alexlib merged commit def8a35 into master Mar 13, 2026
@alexlib alexlib deleted the copilot/sub-pr-105 branch March 13, 2026 21:32
Copilot AI requested a review from alexlib March 13, 2026 21:32
Copilot stopped work on behalf of alexlib due to an error March 13, 2026 21:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants