Skip to content

Widen type annotation for _ensure_target_output_writable to Sequence[str | os.PathLike]#108

Merged
alexlib merged 6 commits intomasterfrom
copilot/sub-pr-105-another-one
Mar 13, 2026
Merged

Widen type annotation for _ensure_target_output_writable to Sequence[str | os.PathLike]#108
alexlib merged 6 commits intomasterfrom
copilot/sub-pr-105-another-one

Conversation

Copy link
Contributor

Copilot AI commented Mar 13, 2026

The parameter annotation for _ensure_target_output_writable was List[str], which misrepresents real callers like ParameterManager.get_target_filenames() that pass Path objects.

Changes

  • pyptv/ptv.py: Updated annotation from List[str]Sequence[str | os.PathLike]; added Sequence to typing imports
# Before
def _ensure_target_output_writable(short_file_bases: List[str]) -> None:

# After
def _ensure_target_output_writable(short_file_bases: Sequence[str | os.PathLike]) -> None:

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

alexlib and others added 4 commits March 12, 2026 23:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Base automatically changed from prepare_path to master March 13, 2026 21:30
…ence[str | os.PathLike]

Co-authored-by: alexlib <747110+alexlib@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback from review on writable folders test implementation Widen type annotation for _ensure_target_output_writable to Sequence[str | os.PathLike] Mar 13, 2026
Copilot AI requested a review from alexlib March 13, 2026 21:32
@alexlib alexlib marked this pull request as ready for review March 13, 2026 21:34
Copilot AI review requested due to automatic review settings March 13, 2026 21:34
@alexlib alexlib merged commit 120839c into master Mar 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexlib alexlib deleted the copilot/sub-pr-105-another-one branch March 13, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants