Address feedback on MemberMatters PR#1
Address feedback on MemberMatters PR#1proffalken merged 2 commits intowyemake:feature/341_record_pronounsfrom
Conversation
|
Oh! I also added the '30 character limit' as a dodgy way to add a consistent space underneath the field (to match the other fields on the profile page). We could always remove that if needed, just would require some extra work. |
|
Amazing, thanks @DanielOaks, but possibly better done against the upstream repo rather than our fork? I'm more than happy to accept the changes here and merge them onto our fork, but it probably makes more sense to do it against the main membermatters repo |
|
Ah, this PR is targeted against the branch for membermatters#342 – if you accept the changes here they'll be bundled into your PR. Happy to open a new PR against the original repo instead though to replace membermatters#342, whatever works best for you! |
|
Ah, ok, I'd missed that. Happy to merge once the Black checks are passing - is that your code or mine? 😂 |
|
Whoops – mine I think! That last commit should fix it 😅 |
a3de669
into
wyemake:feature/341_record_pronouns
This PR fixes the feedback given on membermatters#342 , allows pronoun data to flow back and forth from the profile pages.
I've also changed "Preferred pronouns" to just "Pronouns" – it's a small change but that's the better language to use these days (saying 'preferred' gives people more of a reason to just ignore them if they want to, and argue that's okay, etc).