feature: Allow to customize reqwest client builder#73
Open
luis-araujo-dev wants to merge 1 commit intotypesense:mainfrom
Open
feature: Allow to customize reqwest client builder#73luis-araujo-dev wants to merge 1 commit intotypesense:mainfrom
luis-araujo-dev wants to merge 1 commit intotypesense:mainfrom
Conversation
1 task
Author
|
@RoDmitry will you be able to take a look at the PR? |
RoDmitry
requested changes
Mar 5, 2026
| NodeConfig::new(format!("https://localhost:{}", server_addr.port())).http_builder( | ||
| move |builder| { | ||
| builder | ||
| .add_root_certificate(client_cert.clone()) |
Collaborator
There was a problem hiding this comment.
Is cloning of client_cert required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
After taking a look into #67, I created this PR with the same goal, following maintainers guidance.
This PR allows to customize the reqwest client builder by each node, by using a closure.
I left the default connection timeout value around for non-WASM, but used
connection_timeoutinstead oftimeoutsince it looked to be what's desired and expected.PR Checklist