feature: Allow to customize reqwest client builder#72
Closed
luis-araujo-dev wants to merge 1 commit intotypesense:mainfrom
Closed
feature: Allow to customize reqwest client builder#72luis-araujo-dev wants to merge 1 commit intotypesense:mainfrom
luis-araujo-dev wants to merge 1 commit intotypesense:mainfrom
Conversation
luis-araujo-dev
force-pushed
the
feature/reqwest-client-builder
branch
3 times, most recently
from
d27845b to
229c655
Compare
Collaborator
|
Looks good. Fix the tests, please, so it can be merged. |
luis-araujo-dev
force-pushed
the
feature/reqwest-client-builder
branch
from
229c655 to
ee1be25
Compare
luis-araujo-dev
force-pushed
the
feature/reqwest-client-builder
branch
from
ee1be25 to
f62b28d
Compare
Author
|
I'm having some local issues when setting up wasm-pack. Hopefully the latest changes fixed already all the testing issues there. |
Author
|
I have force pushed some changes. |
Author
|
I'm closing this PR and will be opening a new one shortly after. |
Author
|
Created #73 to replace this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
After taking a look into #67, I created this PR with the same goal, following maintainers guidance.
This PR allows to customize the reqwest client builder by each node, by using a closure.
I left the default connection timeout value around for non-WASM, but used
connection_timeoutinstead oftimeoutsince it looked to be what's desired and expected.PR Checklist