Revert "topology2: tplg-targets-sdca-generic: add echo ref to jack an…#10560
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Feb 20, 2026
Merged
Conversation
…d amp" This reverts commit 96ab79a. The commit will break audio probing on any kernel older than 7.0 and using function topology. We need to figure out something else for echoref, but this must not be released to public.. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
Reverts production topology2 SDCA generic target parameters that enabled echo reference support, because they break audio probing on kernels older than 7.0 when using function topology.
Changes:
- Remove
SDW_ECHO_REF_DAI/SDW_JACK_ECHO_REFflags from the SDCA jack target. - Remove
JACK_RATE/SDW_SPK_ECHO_REF(and related echo-ref variants) from the SDCA amp targets. - Drop the
*-ref_dai-*split-topology variants from the production target list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 20, 2026
lgirdwood
approved these changes
Feb 20, 2026
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
ok, this can be addressed when @bardliao is back.
@udaymb @naveen-manohar fyi - may not impact you atm.
lyakh
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d amp"
This reverts commit 96ab79a.
The commit will break audio probing on any kernel older than 7.0 and using function topology.
We need to figure out something else for echoref, but this must not be released to public..