Open
Conversation
e614839 to
b205d29
Compare
Contributor
|
Yes, and it is very difficult to mock the current implementation in specs. Please consider compacting the options. |
b205d29 to
be4760c
Compare
Contributor
Author
|
The query is only compacted when going through the passed options. |
Contributor
Contributor
Author
|
It would be much easier to just wait for these simple changes to be merged first. |
Adds better handling of query parameters using HTTParty instead of manually. Fills in the gaps in the supported WeatherKit query params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds better handling of query parameters using HTTParty instead of manually.
Fills in the gaps in the supported WeatherKit query params.
Note: I should check if
weather_query_for_optionsis still valid.Old code.