Client: Improve query params with specs#31
Open
woodie wants to merge 2 commits intosuperbasicxyz:mainfrom
Open
Client: Improve query params with specs#31woodie wants to merge 2 commits intosuperbasicxyz:mainfrom
woodie wants to merge 2 commits intosuperbasicxyz:mainfrom
Conversation
Adds better handling of query parameters using HTTParty instead of manually. Fills in the gaps in the supported WeatherKit query params.
Contributor
Author
|
This PR (31) is #28 but also with some specs, so I suppose this can be merged instead. |
woodie
force-pushed
the
more_option_specs
branch
2 times, most recently
from
f2732c8 to
92721a2
Compare
woodie
changed the title
woodie
force-pushed
the
more_option_specs
branch
2 times, most recently
from
9dba516 to
df3c5ee
Compare
woodie
force-pushed
the
more_option_specs
branch
from
df3c5ee to
4d629ff
Compare
Contributor
Author
|
This should be good to go. @jameswpierce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could use more specs on options.params. This PR as a place for the other PR to swipe from.