Open
Conversation
Identify which if statements can coincide and which are mutually exclusive and then reorganize them into `if .. else if ..` blocks to make it clearer which code may or may not apply to any given target. Remove duplicated handling of certain triple cases (e.g. armv7a). Move everything that's not to do with the target architecture/instruction set/calling convention/fpu to the top, then deal with the rest (the messiest and most complicated bits of the code).
Use the online NDK compiler docs at [0] as a reference to document some of the existing behavior and supplement with a linker argument. Don't rely on vague things like "x86 doesn't contain eabi" and just test for the architectures we are targeting in the Android-specific code. [0]: https://developer.android.com/ndk/guides/standalone_toolchain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the GCC triple targeting code
Clean up and clarify Android targeting code
I would certainly appreciate another set of eyes on the changes. The previously logic was highly interleaved and out-of-order, but my aim was to (in the first patch) only refactor and remove redundant code without changing any of the logic.