Draft
Conversation
We do this by storing the default target features in `TargetInfo`.
They should be redundant, the `--target` parameter contains the information already.
And prepare for adding more architecture-specific flags. There are no functional changes here (apart from the `-m32`/`-m64` flags appearing slightly later in the command line, but that shouldn't have any effect).
It is unsound to call between code built with different floating point modes, so let's make sure we pass this flag correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Rework GNU
-mflags to be more robust and better support compilation to different CPU architecture configurations (hard/soft float, endianess, CPU features, sub-architecture, etc.).Builds upon #1266.
Once done:
Replaces part of #791.
Replaces #796.
Replaces #871.
Fixes #710.
Probably fixes #984.
Maybe the GCC part of #268.