Bump k8s.io/apimachinery from 0.34.3 to 0.35.2#1025
Bump k8s.io/apimachinery from 0.34.3 to 0.35.2#1025dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughBumps Go version from 1.24.13 to 1.25.0, upgrades Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: The repository's go.mod declares "go 1.25.0" but CI and Docker pins
are older; update every CI job that sets the go-version key to 1.25.0 (e.g.,
change occurrences of go-version: 1.22 and 1.23 in check-pull-request.yaml and
publish-release.yaml to 1.25.0) and update the Dockerfile base image tag
(ubi9/go-toolset) to an image that provides Go 1.25.0 (or explicitly switch to a
golang:1.25.0 image), ensuring the go.mod directive ("go 1.25.0") matches all
go-version pins and the runtime image.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify Go version pins across common repo config files
set -euo pipefail
echo "== go.mod / go.work =="
fd '^(go\.mod|go\.work)$' -t f | xargs -r cat
echo
echo "== GitHub workflows =="
fd '\.ya?ml$' .github/workflows -t f 2>/dev/null | while read f; do echo "=== $f ==="; cat "$f"; done
echo
echo "== Dockerfiles / container build files =="
fd '(^Dockerfile$|\.Dockerfile$)' -t f | while read f; do echo "=== $f ==="; cat "$f"; doneRepository: openshift-online/ocm-cli
Length of output: 17283
Update CI workflows and Dockerfile to match the go 1.25.0 directive in go.mod.
The Go version pins in your CI workflows are out of sync with the go.mod requirement:
.github/workflows/check-pull-request.yaml(test job): usesgo-version: 1.22.github/workflows/check-pull-request.yaml(lint job): usesgo-version: 1.23.github/workflows/publish-release.yaml: usesgo-version: 1.23docker/Dockerfile: usesubi9/go-toolset:latest(unspecified version)
Update all pins to 1.25.0 to ensure CI builds are consistent with local development and production expectations.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, The repository's go.mod declares "go 1.25.0" but CI and
Docker pins are older; update every CI job that sets the go-version key to
1.25.0 (e.g., change occurrences of go-version: 1.22 and 1.23 in
check-pull-request.yaml and publish-release.yaml to 1.25.0) and update the
Dockerfile base image tag (ubi9/go-toolset) to an image that provides Go 1.25.0
(or explicitly switch to a golang:1.25.0 image), ensuring the go.mod directive
("go 1.25.0") matches all go-version pins and the runtime image.
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.3 to 0.35.2. - [Commits](kubernetes/apimachinery@v0.34.3...v0.35.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.35.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
70067cc to
d6feb97
Compare
Bumps k8s.io/apimachinery from 0.34.3 to 0.35.2.
Commits
72d71eaMerge remote-tracking branch 'origin/master' into release-1.35e2a2dbcBump golang.org/x/crypto to v0.45.02e9c228Merge pull request #135131 from Dev1622/sig-storage/mock-expand-flake-fixf274aacvendor: update vendor and license metadata after replacing BeTrue usage in cs...9445443Resolve lint restriction on BeTrue by introducing Succeed() with contextual e...52154f7Update vendored dependencies5a348c5KEP-5471: Extend tolerations operators (#134665)6f89492Merge pull request #133648 from richabanker/merged-discoveryc77dde2util/sort: Add MergePreservingRelativeOrder for topological sorting729c13dMerge pull request #134624 from yt2985/podcertificates-betaDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)