Skip to content

Bump k8s.io/apimachinery from 0.34.3 to 0.35.2#1025

Open
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/go_modules/k8s.io/apimachinery-0.35.2
Open

Bump k8s.io/apimachinery from 0.34.3 to 0.35.2#1025
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/go_modules/k8s.io/apimachinery-0.35.2

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 2, 2026

Bumps k8s.io/apimachinery from 0.34.3 to 0.35.2.

Commits
  • 72d71ea Merge remote-tracking branch 'origin/master' into release-1.35
  • e2a2dbc Bump golang.org/x/crypto to v0.45.0
  • 2e9c228 Merge pull request #135131 from Dev1622/sig-storage/mock-expand-flake-fix
  • f274aac vendor: update vendor and license metadata after replacing BeTrue usage in cs...
  • 9445443 Resolve lint restriction on BeTrue by introducing Succeed() with contextual e...
  • 52154f7 Update vendored dependencies
  • 5a348c5 KEP-5471: Extend tolerations operators (#134665)
  • 6f89492 Merge pull request #133648 from richabanker/merged-discovery
  • c77dde2 util/sort: Add MergePreservingRelativeOrder for topological sorting
  • 729c13d Merge pull request #134624 from yt2985/podcertificates-beta
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Mar 2, 2026
@openshift-ci openshift-ci bot requested a review from rcampos2029 March 2, 2026 08:58
@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign rcampos2029 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 70067cc and d6feb97.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Walkthrough

Bumps Go version from 1.24.13 to 1.25.0, upgrades k8s.io/apimachinery from v0.34.3 to v0.35.2, and removes the indirect github.com/gogo/protobuf v1.3.2 entry in go.mod. No exported API changes.

Changes

Cohort / File(s) Summary
Go dependency updates
go.mod
Updated Go toolchain to 1.25.0, bumped k8s.io/apimachinery to v0.35.2, and removed indirect dependency github.com/gogo/protobuf v1.3.2. Lines changed: +2 / -3.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title specifically mentions the main dependency bump (k8s.io/apimachinery from 0.34.3 to 0.35.2) which is the primary change, though it omits the Go version bump also present in the changeset.
Description check ✅ Passed The description is directly related to the changeset, detailing the k8s.io/apimachinery bump with upstream commits and Dependabot information.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dependabot/go_modules/k8s.io/apimachinery-0.35.2

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2026

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 3: The repository's go.mod declares "go 1.25.0" but CI and Docker pins
are older; update every CI job that sets the go-version key to 1.25.0 (e.g.,
change occurrences of go-version: 1.22 and 1.23 in check-pull-request.yaml and
publish-release.yaml to 1.25.0) and update the Dockerfile base image tag
(ubi9/go-toolset) to an image that provides Go 1.25.0 (or explicitly switch to a
golang:1.25.0 image), ensuring the go.mod directive ("go 1.25.0") matches all
go-version pins and the runtime image.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between bf148ad and 70067cc.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

module github.com/openshift-online/ocm-cli

go 1.24.6
go 1.25.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify Go version pins across common repo config files

set -euo pipefail

echo "== go.mod / go.work =="
fd '^(go\.mod|go\.work)$' -t f | xargs -r cat

echo
echo "== GitHub workflows =="
fd '\.ya?ml$' .github/workflows -t f 2>/dev/null | while read f; do echo "=== $f ==="; cat "$f"; done

echo
echo "== Dockerfiles / container build files =="
fd '(^Dockerfile$|\.Dockerfile$)' -t f | while read f; do echo "=== $f ==="; cat "$f"; done

Repository: openshift-online/ocm-cli

Length of output: 17283


Update CI workflows and Dockerfile to match the go 1.25.0 directive in go.mod.

The Go version pins in your CI workflows are out of sync with the go.mod requirement:

  • .github/workflows/check-pull-request.yaml (test job): uses go-version: 1.22
  • .github/workflows/check-pull-request.yaml (lint job): uses go-version: 1.23
  • .github/workflows/publish-release.yaml: uses go-version: 1.23
  • docker/Dockerfile: uses ubi9/go-toolset:latest (unspecified version)

Update all pins to 1.25.0 to ensure CI builds are consistent with local development and production expectations.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 3, The repository's go.mod declares "go 1.25.0" but CI and
Docker pins are older; update every CI job that sets the go-version key to
1.25.0 (e.g., change occurrences of go-version: 1.22 and 1.23 in
check-pull-request.yaml and publish-release.yaml to 1.25.0) and update the
Dockerfile base image tag (ubi9/go-toolset) to an image that provides Go 1.25.0
(or explicitly switch to a golang:1.25.0 image), ensuring the go.mod directive
("go 1.25.0") matches all go-version pins and the runtime image.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2026
@openshift-merge-robot
Copy link
Collaborator

rebase

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.3 to 0.35.2.
- [Commits](kubernetes/apimachinery@v0.34.3...v0.35.2)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.35.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/apimachinery-0.35.2 branch from 70067cc to d6feb97 Compare March 3, 2026 22:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant