Bump k8s.io/apimachinery from 0.34.3 to 0.35.1#1014
Bump k8s.io/apimachinery from 0.34.3 to 0.35.1#1014dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.3 to 0.35.1. - [Commits](kubernetes/apimachinery@v0.34.3...v0.35.1) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.35.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughUpdates Go toolchain from 1.24.6 to 1.25.0 and upgrades k8s.io/apimachinery from v0.34.3 to v0.35.1. Removes the indirect dependency on github.com/gogo/protobuf v1.3.2. Total change: 2 lines added, 3 lines removed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@go.mod`:
- Line 3: go.mod declares "go 1.25.0" which conflicts with CI workflows
(check-pull-request.yaml and publish-release.yaml) that use older Go versions;
fix by either updating the CI workflow go-version to 1.25.0 to match the go.mod
or downgrading the go directive in go.mod (the "go 1.25.0" line) to the version
used by CI (e.g., 1.23 or 1.22) so both are consistent; ensure the chosen
version is supported by your CI images and run a quick CI check after the
change.
- Line 33: Confirm that the bumped module entry k8s.io/apimachinery v0.35.1 is
compatible with the single import site (the import of
"k8s.io/apimachinery/pkg/util/sets") by running the test suite and exercising
the code path in pkg/arguments/interactive.go that uses sets; then run go mod
tidy and ensure it makes no changes (or commit any intentional tidy changes) so
the go.mod/go.sum are clean. If tests or tidy surface dependency issues, revert
or resolve them (adjust import usage or pin versions) and re-run tests and go
mod tidy until clean.
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check for CI configuration files
find . -type f \( -name "*.yml" -o -name "*.yaml" \) -path "*/.github/*" -o -name ".gitlab-ci.yml" -o -name ".circleci/config.yml" | head -20Repository: openshift-online/ocm-cli
Length of output: 177
🏁 Script executed:
# Search for Go version references in the repo
rg -n 'go\s*1\.' --type yaml --type yml --type json | head -30Repository: openshift-online/ocm-cli
Length of output: 95
🏁 Script executed:
# Check the current go.mod file to understand the context
head -20 go.modRepository: openshift-online/ocm-cli
Length of output: 713
🏁 Script executed:
# Search for any toolchain directives or Go version constraints
rg -n 'toolchain|go\s+1\.' go.mod go.sum 2>/dev/null | head -20Repository: openshift-online/ocm-cli
Length of output: 86
🏁 Script executed:
cat -n .github/workflows/check-pull-request.yamlRepository: openshift-online/ocm-cli
Length of output: 3199
🏁 Script executed:
cat -n .github/workflows/publish-release.yamlRepository: openshift-online/ocm-cli
Length of output: 6007
🏁 Script executed:
# Check dependabot config for any Go version specifications
cat -n .github/dependabot.ymlRepository: openshift-online/ocm-cli
Length of output: 245
Update CI workflows to use Go 1.25.0 or downgrade go.mod
CI workflows (check-pull-request.yaml and publish-release.yaml) specify Go versions 1.22 and 1.23, but go.mod declares go 1.25.0. This mismatch will cause build failures. Either update all CI workflows to use go-version: 1.25.0, or downgrade go.mod to a version available in CI (1.22 or 1.23).
🤖 Prompt for AI Agents
In `@go.mod` at line 3, go.mod declares "go 1.25.0" which conflicts with CI
workflows (check-pull-request.yaml and publish-release.yaml) that use older Go
versions; fix by either updating the CI workflow go-version to 1.25.0 to match
the go.mod or downgrading the go directive in go.mod (the "go 1.25.0" line) to
the version used by CI (e.g., 1.23 or 1.22) so both are consistent; ensure the
chosen version is supported by your CI images and run a quick CI check after the
change.
| google.golang.org/grpc v1.77.0 | ||
| gopkg.in/yaml.v3 v3.0.1 | ||
| k8s.io/apimachinery v0.34.3 | ||
| k8s.io/apimachinery v0.35.1 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find usage sites of apimachinery imports to assess potential breakage.
rg -n --glob '!**/vendor/**' 'k8s\.io/apimachinery'
echo "---"
# Verify module graph shows expected version.
if [ -f go.mod ]; then
echo "go.mod content around apimachinery:"
grep -n 'apimachinery' go.mod
fiRepository: openshift-online/ocm-cli
Length of output: 684
🏁 Script executed:
#!/bin/bash
# Check if go.mod tidy is clean
if [ -f go.mod ]; then
echo "Checking go.mod state:"
head -40 go.mod
echo "---"
echo "Looking for apimachinery and related k8s.io dependencies:"
grep -E 'k8s\.io/(api|apimachinery|client-go)' go.mod
fiRepository: openshift-online/ocm-cli
Length of output: 1463
🏁 Script executed:
#!/bin/bash
# Search for actual imports of apimachinery packages to understand usage
rg --glob '*.go' 'from "k8s\.io/apimachinery' -A 1 | head -50
rg --glob '*.go' 'import.*k8s\.io/apimachinery' -B 1 -A 1 | head -50Repository: openshift-online/ocm-cli
Length of output: 50
Verify v0.35.1 compatibility with the single usage site and ensure go mod tidy is clean.
The apimachinery upgrade is already applied with minimal scope—only pkg/arguments/interactive.go imports k8s.io/apimachinery/pkg/util/sets. Run tests locally and confirm go mod tidy leaves no changes to ensure the upgrade integrates cleanly.
🤖 Prompt for AI Agents
In `@go.mod` at line 33, Confirm that the bumped module entry k8s.io/apimachinery
v0.35.1 is compatible with the single import site (the import of
"k8s.io/apimachinery/pkg/util/sets") by running the test suite and exercising
the code path in pkg/arguments/interactive.go that uses sets; then run go mod
tidy and ensure it makes no changes (or commit any intentional tidy changes) so
the go.mod/go.sum are clean. If tests or tidy surface dependency issues, revert
or resolve them (adjust import usage or pin versions) and re-run tests and go
mod tidy until clean.
|
Superseded by #1025. |
Bumps k8s.io/apimachinery from 0.34.3 to 0.35.1.
Commits
72d71eaMerge remote-tracking branch 'origin/master' into release-1.35e2a2dbcBump golang.org/x/crypto to v0.45.02e9c228Merge pull request #135131 from Dev1622/sig-storage/mock-expand-flake-fixf274aacvendor: update vendor and license metadata after replacing BeTrue usage in cs...9445443Resolve lint restriction on BeTrue by introducing Succeed() with contextual e...52154f7Update vendored dependencies5a348c5KEP-5471: Extend tolerations operators (#134665)6f89492Merge pull request #133648 from richabanker/merged-discoveryc77dde2util/sort: Add MergePreservingRelativeOrder for topological sorting729c13dMerge pull request #134624 from yt2985/podcertificates-betaDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)