Guard MTP test targets with IsTestingPlatformApplication to prevent interference with VSTest projects#7539
Draft
Guard MTP test targets with IsTestingPlatformApplication to prevent interference with VSTest projects#7539
IsTestingPlatformApplication to prevent interference with VSTest projects#7539Conversation
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with UseMSBuildTestInfrastructure not opting-in MTP
Guard MTP test targets with Mar 12, 2026
IsTestingPlatformApplication to prevent interference with VSTest projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
UseMSBuildTestInfrastructure=trueis set (e.g., inDirectory.Build.props), the MTP.MSBuild package was hooking MTP-specific execution logic into VSTest projects that never opted into MTP (IsTestingPlatformApplication != true).Changes
Microsoft.Testing.Platform.MSBuild.targets: AddedAND '$(IsTestingPlatformApplication)' == 'true'to_MTPTestTarget's condition — preventsInvokeTestingPlatformfrom runningAfterTargets="Test"on non-MTP projects whenUseMSBuildTestInfrastructure=true.Microsoft.Testing.Platform.MSBuild.CustomTestTarget.targets: Added the same guard to theTesttarget — prevents MTP's customTesttarget from overriding SDK behavior for non-MTP projects whenUseMSBuildTestInfrastructure=false.Both are target-level conditions (evaluated at runtime), so they correctly observe the final settled value of
IsTestingPlatformApplication, including cases whereMSTest.TestAdapter.targetssets it tofalseafter the package's targets are imported.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.