Skip to content

Adding fix for scrim semantics #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranjal-glowingstar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding fix for scrim semantics #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...fication/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,17 @@ import androidx.compose.ui.layout.onGloballyPositioned
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.LiveRegionMode
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.liveRegion
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.times
import com.microsoft.fluentui.notification.R
import com.microsoft.fluentui.theme.token.FluentIcon
import com.microsoft.fluentui.theme.token.Icon
import com.microsoft.fluentui.theme.token.StateColor
Expand Down Expand Up @@ -839,6 +842,7 @@ fun Scrim(
)

if (scrimColor.alpha > 0f) {
val scrimContentDescription = stringResource(R.string.scrim_content_description)
Box(
modifier = modifier
.fillMaxSize()
Expand All @@ -848,6 +852,9 @@ fun Scrim(
indication = null,
onClick = onDismiss
)
.semantics {
contentDescription = scrimContentDescription
}
)
}
}
4 changes: 3 additions & 1 deletion fluentui_notification/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources></resources>
<resources>
<string name="scrim_content_description">Dismiss Expanded notifications</string>
</resources>