Adding fix for scrim semantics#819
Open
pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
Open
Adding fix for scrim semantics#819pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
@pranjal-glowingstar please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem :-
On expanding the stacked snackbars, the scrim comes into focus. Talkback announces it as "Unlabeled - Double Tap to Activate". We need to update the string announced.
Root cause :-
There is no semantic content description present in Scrim in order for talkback to recite, hence reciting "Unlabeled".
Fix :-
Added the string resource and created a descriptive string for Scrim.
Validations:-
Build successful and behaviour is working as expected.
(how the change was tested, including both manual and automated tests)
Screenshots
Pull request checklist
This PR has considered: