-
Notifications
You must be signed in to change notification settings - Fork 21
U/sgriffin/vc2026 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephenegriffin
wants to merge
21
commits into
main
Choose a base branch
from
u/sgriffin/vc2026
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+190
−624
Open
U/sgriffin/vc2026 #167
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c39ab11
Upgrade to Visual Studio 2026 (v145 toolset)
stephenegriffin 397ed25
ensure config
stephenegriffin 7a8ec30
install sdk
stephenegriffin f8efc98
update codeql
stephenegriffin 2405bc0
add arm builds
stephenegriffin f90d65c
Merge branch 'main' into u/sgriffin/vc2026
stephenegriffin 8e457ff
update ci for arm
stephenegriffin 8c7b20d
Remove Prefast configurations from mapistub
stephenegriffin bba20d7
replace broken clang action
stephenegriffin 14f70be
update clang action
stephenegriffin 0f6a5a4
Update .github/workflows/codeql.yml
stephenegriffin a0109fb
Update .github/workflows/codeql.yml
stephenegriffin 4186348
Update mapistub.sln
stephenegriffin eda8175
Update .github/workflows/github-ci.yml
stephenegriffin 3c74dae
fix sdk installer
stephenegriffin 096a611
better handling of sdk dependency
stephenegriffin 8862bc8
alternate attempt at sdk
stephenegriffin 8746341
better hash
stephenegriffin d7186a2
clean up project
stephenegriffin b41fde2
add arm builds
stephenegriffin a5125bb
fix args
stephenegriffin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,8 @@ permissions: | |||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||
| analyze: | ||||||||||||||||||||||||
| name: Analyze (${{ matrix.language }}) | ||||||||||||||||||||||||
| runs-on: windows-latest | ||||||||||||||||||||||||
| # Use VS 2026 preview runner (GA May 4, 2026, then switch to windows-2025) | ||||||||||||||||||||||||
| runs-on: windows-2025-vs2026 | ||||||||||||||||||||||||
stephenegriffin marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||
| permissions: | ||||||||||||||||||||||||
| packages: read | ||||||||||||||||||||||||
| actions: read | ||||||||||||||||||||||||
|
|
@@ -39,9 +40,42 @@ jobs: | |||||||||||||||||||||||
| with: | ||||||||||||||||||||||||
| submodules: 'recursive' | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| - name: Install Windows 11 SDK (10.0.22621.0) | ||||||||||||||||||||||||
| shell: pwsh | ||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||
| $sdkPath = "${env:ProgramFiles(x86)}\Windows Kits\10\Include\10.0.22621.0" | ||||||||||||||||||||||||
| if (Test-Path $sdkPath) { | ||||||||||||||||||||||||
| Write-Host "Windows SDK 10.0.22621.0 already installed" | ||||||||||||||||||||||||
| exit 0 | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| # Download and verify installer | ||||||||||||||||||||||||
| $installer = "$env:TEMP\winsdksetup.exe" | ||||||||||||||||||||||||
| $expectedHash = "73FE3CC0E50D946D0C0A83A1424111E60DEE23F0803E305A8974A963B58290C0" | ||||||||||||||||||||||||
| Write-Host "Downloading Windows 11 SDK 10.0.22621.0..." | ||||||||||||||||||||||||
| Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| # Verify SHA256 hash | ||||||||||||||||||||||||
| $actualHash = (Get-FileHash -Path $installer -Algorithm SHA256).Hash | ||||||||||||||||||||||||
| if ($actualHash -ne $expectedHash) { | ||||||||||||||||||||||||
| Write-Error "SHA256 hash mismatch! Expected: $expectedHash, Got: $actualHash" | ||||||||||||||||||||||||
stephenegriffin marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||
| exit 1 | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| Write-Host "SHA256 verified: $actualHash" | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| # Install SDK | ||||||||||||||||||||||||
| Write-Host "Installing SDK (this may take a few minutes)..." | ||||||||||||||||||||||||
| $proc = Start-Process -FilePath $installer -ArgumentList "/features OptionId.DesktopCPPx64 OptionId.DesktopCPPx86 OptionId.DesktopCPParm64 /quiet /norestart /log $env:TEMP\sdk_install.log" -Wait -PassThru | ||||||||||||||||||||||||
| if (!(Test-Path $sdkPath)) { | ||||||||||||||||||||||||
| Get-Content "$env:TEMP\sdk_install.log" -ErrorAction SilentlyContinue | Select-Object -Last 50 | ||||||||||||||||||||||||
| Write-Error "Windows SDK installation failed" | ||||||||||||||||||||||||
|
Comment on lines
+69
to
+71
|
||||||||||||||||||||||||
| if (!(Test-Path $sdkPath)) { | |
| Get-Content "$env:TEMP\sdk_install.log" -ErrorAction SilentlyContinue | Select-Object -Last 50 | |
| Write-Error "Windows SDK installation failed" | |
| if ($proc.ExitCode -ne 0 -or !(Test-Path $sdkPath)) { | |
| Write-Host "Last 50 lines of SDK install log (if available):" | |
| Get-Content "$env:TEMP\sdk_install.log" -ErrorAction SilentlyContinue | Select-Object -Last 50 | |
| if ($proc.ExitCode -ne 0) { | |
| Write-Error "Windows SDK installer exited with code $($proc.ExitCode)." | |
| } elseif (!(Test-Path $sdkPath)) { | |
| Write-Error "Windows SDK installation may have failed: SDK path '$sdkPath' not found after installer completed successfully." | |
| } |
Comment on lines
+52
to
+73
Copilot
AI
Feb 18, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This SDK install step pins a SHA256 for a fwlink URL. fwlink targets can change over time, which risks random CI failures when the binary hash changes. Prefer installing via a stable package/component mechanism (or a stable, versioned direct download URL) rather than a mutable fwlink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -13,13 +13,25 @@ permissions: | |||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||||
| build: | ||||||||||||||||||||||||||
| runs-on: windows-latest | ||||||||||||||||||||||||||
| # Use VS 2026 preview runner (GA May 4, 2026, then switch to windows-2025) | ||||||||||||||||||||||||||
| runs-on: windows-2025-vs2026 | ||||||||||||||||||||||||||
stephenegriffin marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||
| permissions: | ||||||||||||||||||||||||||
| security-events: write | ||||||||||||||||||||||||||
| strategy: | ||||||||||||||||||||||||||
| fail-fast: false | ||||||||||||||||||||||||||
| matrix: | ||||||||||||||||||||||||||
| configuration: [ 'Release', 'Debug', 'Release_Unicode', 'Debug_Unicode' ] | ||||||||||||||||||||||||||
| platform: [ 'Win32', 'x64' ] | ||||||||||||||||||||||||||
| platform: [ 'Win32', 'x64', 'ARM64', 'ARM64EC' ] | ||||||||||||||||||||||||||
| exclude: | ||||||||||||||||||||||||||
| # ARM64/ARM64EC only need Unicode builds | ||||||||||||||||||||||||||
| - platform: ARM64 | ||||||||||||||||||||||||||
| configuration: Release | ||||||||||||||||||||||||||
| - platform: ARM64 | ||||||||||||||||||||||||||
| configuration: Debug | ||||||||||||||||||||||||||
| - platform: ARM64EC | ||||||||||||||||||||||||||
| configuration: Release | ||||||||||||||||||||||||||
| - platform: ARM64EC | ||||||||||||||||||||||||||
| configuration: Debug | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||
| - name: Harden Runner | ||||||||||||||||||||||||||
|
|
@@ -32,6 +44,39 @@ jobs: | |||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||
| submodules: 'recursive' | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| - name: Install Windows 11 SDK (10.0.22621.0) | ||||||||||||||||||||||||||
| shell: pwsh | ||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| $sdkPath = "${env:ProgramFiles(x86)}\Windows Kits\10\Include\10.0.22621.0" | ||||||||||||||||||||||||||
| if (Test-Path $sdkPath) { | ||||||||||||||||||||||||||
| Write-Host "Windows SDK 10.0.22621.0 already installed" | ||||||||||||||||||||||||||
| exit 0 | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Download and verify installer | ||||||||||||||||||||||||||
| $installer = "$env:TEMP\winsdksetup.exe" | ||||||||||||||||||||||||||
| $expectedHash = "73FE3CC0E50D946D0C0A83A1424111E60DEE23F0803E305A8974A963B58290C0" | ||||||||||||||||||||||||||
| Write-Host "Downloading Windows 11 SDK 10.0.22621.0..." | ||||||||||||||||||||||||||
| Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Verify SHA256 hash | ||||||||||||||||||||||||||
| $actualHash = (Get-FileHash -Path $installer -Algorithm SHA256).Hash | ||||||||||||||||||||||||||
| if ($actualHash -ne $expectedHash) { | ||||||||||||||||||||||||||
| Write-Error "SHA256 hash mismatch! Expected: $expectedHash, Got: $actualHash" | ||||||||||||||||||||||||||
| exit 1 | ||||||||||||||||||||||||||
|
Comment on lines
+56
to
+66
|
||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| Write-Host "SHA256 verified: $actualHash" | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Install SDK | ||||||||||||||||||||||||||
| Write-Host "Installing SDK (this may take a few minutes)..." | ||||||||||||||||||||||||||
| $proc = Start-Process -FilePath $installer -ArgumentList "/features OptionId.DesktopCPPx64 OptionId.DesktopCPPx86 OptionId.DesktopCPParm64 /quiet /norestart /log $env:TEMP\sdk_install.log" -Wait -PassThru | ||||||||||||||||||||||||||
stephenegriffin marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||
| if (!(Test-Path $sdkPath)) { | ||||||||||||||||||||||||||
| Get-Content "$env:TEMP\sdk_install.log" -ErrorAction SilentlyContinue | Select-Object -Last 50 | ||||||||||||||||||||||||||
|
Comment on lines
+72
to
+74
|
||||||||||||||||||||||||||
| $proc = Start-Process -FilePath $installer -ArgumentList "/features OptionId.DesktopCPPx64 OptionId.DesktopCPPx86 OptionId.DesktopCPParm64 /quiet /norestart /log $env:TEMP\sdk_install.log" -Wait -PassThru | |
| if (!(Test-Path $sdkPath)) { | |
| Get-Content "$env:TEMP\sdk_install.log" -ErrorAction SilentlyContinue | Select-Object -Last 50 | |
| $logPath = Join-Path $env:TEMP "sdk_install.log" | |
| $proc = Start-Process -FilePath $installer -ArgumentList "/features OptionId.DesktopCPPx64 OptionId.DesktopCPPx86 OptionId.DesktopCPParm64 /quiet /norestart /log `"$logPath`"" -Wait -PassThru | |
| if ($proc.ExitCode -ne 0) { | |
| Get-Content $logPath -ErrorAction SilentlyContinue | Select-Object -Last 50 | |
| Write-Error "Windows SDK installer exited with code $($proc.ExitCode)" | |
| exit 1 | |
| } | |
| if (!(Test-Path $sdkPath)) { | |
| Get-Content $logPath -ErrorAction SilentlyContinue | Select-Object -Last 50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project> | ||
| <PropertyGroup> | ||
| <!-- VS 2026 Toolset --> | ||
stephenegriffin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <PlatformToolset>v145</PlatformToolset> | ||
stephenegriffin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <!-- Windows 11 SDK (pinned for reproducible builds) --> | ||
| <WindowsTargetPlatformVersion>10.0.22621.0</WindowsTargetPlatformVersion> | ||
|
|
||
| <!-- Security Features (PropertyGroup level) --> | ||
| <!-- Note: Spectre mitigated libs may not be available for ARM64/ARM64EC --> | ||
| <SpectreMitigation Condition="'$(Platform)' != 'ARM64' AND '$(Platform)' != 'ARM64EC'">Spectre</SpectreMitigation> | ||
| <SpectreMitigation Condition="'$(Platform)' == 'ARM64' OR '$(Platform)' == 'ARM64EC'">false</SpectreMitigation> | ||
| <ControlFlowGuard>Guard</ControlFlowGuard> | ||
| <GuardEHContMetadata>true</GuardEHContMetadata> | ||
stephenegriffin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </PropertyGroup> | ||
|
|
||
| <!-- Compiler Settings - Quality & Security Baseline --> | ||
| <!-- CET (Control-flow Enforcement Technology) enabled by default, disabled for ARM64/ARM64EC below --> | ||
| <ItemDefinitionGroup> | ||
| <ClCompile> | ||
| <WarningLevel>Level4</WarningLevel> | ||
| <TreatWarningAsError>true</TreatWarningAsError> | ||
| <SDLCheck>true</SDLCheck> | ||
| <LanguageStandard>stdcpplatest</LanguageStandard> | ||
| </ClCompile> | ||
| <Link> | ||
| <CETCompat>true</CETCompat> | ||
| </Link> | ||
| </ItemDefinitionGroup> | ||
|
|
||
| <!-- Disable CET for ARM64/ARM64EC (not supported) --> | ||
| <ItemDefinitionGroup Condition="'$(Platform)' == 'ARM64' OR '$(Platform)' == 'ARM64EC'"> | ||
| <Link> | ||
| <CETCompat>false</CETCompat> | ||
| </Link> | ||
| </ItemDefinitionGroup> | ||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing
clang-format-17viaapt-getonubuntu-latestis not stable because the available package versions change as the runner image updates. To avoid formatting CI breaking when the package isn’t available, consider using the previously used clang-format action, pinning an Ubuntu version, or adding the LLVM apt repository for the desired clang-format version.