U/sgriffin/vc2026 by stephenegriffin · Pull Request #167 · microsoft/MAPIStubLibrary

stephenegriffin · 2026-02-06T20:54:40Z

No description provided.

- Create Directory.Build.props for centralized build configuration - Update solution file to VS 18 format - Update .vsconfig to require Windows 11 SDK (10.0.22621.0) - Remove PlatformToolset and WindowsTargetPlatformVersion from mapistub.vcxproj - Remove Guardian .gdn ruleset references (CI-only dependency) Breaking change: Requires Visual Studio 2026

github-actions · 2026-02-06T20:57:43Z

Test Results

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 3c74dae. ± Comparison against base commit 9d1e8b0.

♻️ This comment has been updated with latest results.

Prefast analysis now enabled on-demand via MSBuild property (/p:EnablePREfast=true) instead of separate build configurations.

Copilot

Pull request overview

Updates the Windows/Visual Studio build setup to target a newer toolset/SDK baseline and align CI/security scanning workflows with those build requirements.

Changes:

Centralizes MSBuild defaults (toolset/SDK pin + security/quality flags) via Directory.Build.props and removes per-configuration duplication from the .vcxproj.
Updates the solution/project configurations (drops Prefast configs) and bumps the .sln Visual Studio version metadata.
Updates GitHub Actions workflows (new Windows runner label, ARM64EC matrix, Windows 11 SDK install step) and bumps CodeQL action SHAs.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`mapistub.vcxproj`	Removes per-config toolset/SDK/security flags and drops Prefast/Fuzz ARM64* configurations in favor of repo-wide props.
`mapistub.sln`	Updates VS version metadata and removes Prefast solution configurations.
`Directory.Build.props`	Introduces centralized toolset/SDK pin and baseline compiler/link security settings.
`.vsconfig`	Updates required SDK component to Windows 11 SDK 22621.
`.github/workflows/github-ci.yml`	Switches to a VS2026 runner label, adds ARM64EC to the build matrix, and installs Windows 11 SDK.
`.github/workflows/codeql.yml`	Switches to a VS2026 runner label, installs Windows 11 SDK, and updates CodeQL action SHAs.
`.github/workflows/scorecards.yml`	Updates `upload-sarif` action SHA.
`.github/workflows/devskim.yml`	Updates `upload-sarif` action SHA.
`.github/workflows/clang.yml`	Replaces the clang-format action with an apt-based install + manual formatting check script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/codeql.yml

mapistub.sln

.github/workflows/github-ci.yml

.github/workflows/codeql.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T22:56:27Z

.github/workflows/codeql.yml

+          Write-Host "Downloading Windows 11 SDK 10.0.22621.0..."
+          $installer = "$env:TEMP\winsdksetup.exe"
+          & "${{ github.workspace }}\scripts\install-winsdk.ps1"
+


The "Install Windows 11 SDK" step appears broken: it logs "Downloading..." and defines $installer, but never downloads or runs it. Instead it calls scripts/install-winsdk.ps1, which does not exist in the repo (only scripts/clang.ps1 is present). This will fail the CodeQL workflow on fresh runners. Either add the referenced script (and have it perform the download/install) or inline the same download/install logic used in github-ci.yml and remove the unused variables/log lines.

Suggested change

Write-Host "Downloading Windows 11 SDK 10.0.22621.0..."

$installer = "$env:TEMP\winsdksetup.exe"

& "${{ github.workspace }}\scripts\install-winsdk.ps1"

Write-Host "Windows SDK 10.0.22621.0 not found. Downloading installer..."

$installer = Join-Path $env:TEMP "winsdksetup.exe"

$sdkUrl = "https://go.microsoft.com/fwlink/?linkid=2196241"

Write-Host "Downloading Windows 11 SDK 10.0.22621.0 from $sdkUrl to $installer"

Invoke-WebRequest -Uri $sdkUrl -OutFile $installer

Write-Host "Running Windows 11 SDK installer..."

$arguments = "/quiet /norestart"

$process = Start-Process -FilePath $installer -ArgumentList $arguments -PassThru -Wait

if ($process.ExitCode -ne 0) {

Write-Error "Windows 11 SDK installer failed with exit code $($process.ExitCode)"

exit $process.ExitCode

}

Write-Host "Cleaning up installer..."

if (Test-Path $installer) {

Remove-Item $installer -Force

}

if (-not (Test-Path $sdkPath)) {

Write-Error "Windows 11 SDK 10.0.22621.0 did not install correctly (path '$sdkPath' not found)"

exit 1

}

Write-Host "Windows SDK 10.0.22621.0 installed successfully"

Copilot · 2026-02-17T22:56:27Z

.github/workflows/github-ci.yml

+        $installer = "$env:TEMP\winsdksetup.exe"
+        Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer


This step downloads and executes the Windows SDK installer directly from a fwlink URL without any authenticity verification (e.g., checking Authenticode signature and/or a pinned hash). To reduce supply-chain risk, consider validating the downloaded binary before executing it, or installing the SDK via a package manager/mechanism that provides integrity verification.

Suggested change

$installer = "$env:TEMP\winsdksetup.exe"

Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer

$installer = "$env:TEMP\winsdksetup.exe"

# SHA256 hash of the official Windows 11 SDK 10.0.22621.0 installer.

# TODO: Replace this value with the official SHA256 from Microsoft if the SDK installer is updated.

$expectedHash = "REPLACE_WITH_OFFICIAL_SHA256_HASH"

Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer

$actualHash = (Get-FileHash -Path $installer -Algorithm SHA256).Hash

if ($actualHash -ne $expectedHash) {

Write-Error "Downloaded Windows SDK installer hash mismatch. Expected $expectedHash but got $actualHash."

Remove-Item -Path $installer -ErrorAction SilentlyContinue

exit 1

}

stephenegriffin added 4 commits February 6, 2026 13:22

ensure config

397ed25

install sdk

7a8ec30

update codeql

f8efc98

stephenegriffin mentioned this pull request Feb 6, 2026

Retarget platform toolset #163

Closed

stephenegriffin and others added 6 commits February 6, 2026 18:14

add arm builds

2405bc0

Merge branch 'main' into u/sgriffin/vc2026

f90d65c

update ci for arm

8e457ff

Remove Prefast configurations from mapistub

8c7b20d

Prefast analysis now enabled on-demand via MSBuild property (/p:EnablePREfast=true) instead of separate build configurations.

replace broken clang action

bba20d7

update clang action

14f70be

stephenegriffin enabled auto-merge February 17, 2026 22:43

stephenegriffin requested a review from Copilot February 17, 2026 22:44

Copilot started reviewing on behalf of stephenegriffin February 17, 2026 22:45 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

.github/workflows/codeql.yml Outdated Show resolved Hide resolved

mapistub.sln Outdated Show resolved Hide resolved

.github/workflows/github-ci.yml Show resolved Hide resolved

.github/workflows/codeql.yml Outdated Show resolved Hide resolved

stephenegriffin and others added 5 commits February 17, 2026 17:48

Update .github/workflows/codeql.yml

0f6a5a4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/codeql.yml

a0109fb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update mapistub.sln

4186348

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/github-ci.yml

eda8175

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix sdk installer

3c74dae

stephenegriffin requested a review from Copilot February 17, 2026 22:53

Copilot started reviewing on behalf of stephenegriffin February 17, 2026 22:53 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

U/sgriffin/vc2026#167

U/sgriffin/vc2026#167
stephenegriffin wants to merge 15 commits intomainfrom
u/sgriffin/vc2026

stephenegriffin commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-          Write-Host "Downloading Windows 11 SDK 10.0.22621.0..."
-          $installer = "$env:TEMP\winsdksetup.exe"
-          & "${{ github.workspace }}\scripts\install-winsdk.ps1"
+          Write-Host "Windows SDK 10.0.22621.0 not found. Downloading installer..."
+          $installer = Join-Path $env:TEMP "winsdksetup.exe"
+          $sdkUrl = "https://go.microsoft.com/fwlink/?linkid=2196241"
+          Write-Host "Downloading Windows 11 SDK 10.0.22621.0 from $sdkUrl to $installer"
+          Invoke-WebRequest -Uri $sdkUrl -OutFile $installer
+          Write-Host "Running Windows 11 SDK installer..."
+          $arguments = "/quiet /norestart"
+          $process = Start-Process -FilePath $installer -ArgumentList $arguments -PassThru -Wait
+          if ($process.ExitCode -ne 0) {
+            Write-Error "Windows 11 SDK installer failed with exit code $($process.ExitCode)"
+            exit $process.ExitCode
+          }
+          Write-Host "Cleaning up installer..."
+          if (Test-Path $installer) {
+            Remove-Item $installer -Force
+          }
+          if (-not (Test-Path $sdkPath)) {
+            Write-Error "Windows 11 SDK 10.0.22621.0 did not install correctly (path '$sdkPath' not found)"
+            exit 1
+          }
+          Write-Host "Windows SDK 10.0.22621.0 installed successfully"

		$installer = "$env:TEMP\winsdksetup.exe"
		Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer

-        $installer = "$env:TEMP\winsdksetup.exe"
-        Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer
+        $installer = "$env:TEMP\winsdksetup.exe"
+        # SHA256 hash of the official Windows 11 SDK 10.0.22621.0 installer.
+        # TODO: Replace this value with the official SHA256 from Microsoft if the SDK installer is updated.
+        $expectedHash = "REPLACE_WITH_OFFICIAL_SHA256_HASH"
+        Invoke-WebRequest -Uri "https://go.microsoft.com/fwlink/?linkid=2196241" -OutFile $installer
+        $actualHash = (Get-FileHash -Path $installer -Algorithm SHA256).Hash
+        if ($actualHash -ne $expectedHash) {
+          Write-Error "Downloaded Windows SDK installer hash mismatch. Expected $expectedHash but got $actualHash."
+          Remove-Item -Path $installer -ErrorAction SilentlyContinue
+          exit 1
+        }

Conversation

stephenegriffin commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Feb 6, 2026 •

edited

Loading