Fix ubuntu dependencies not to break ROS installation#474
Open
Fix ubuntu dependencies not to break ROS installation#474
Conversation
themarpe
requested changes
Jan 4, 2022
Collaborator
themarpe
left a comment
themarpe
left a comment
There was a problem hiding this comment.
This seems to be able to break ARM ROS installations
IMO, check for ROS OS and install / not install pyqt5 package based on that information
# Conflicts: # docs/source/_static/install_dependencies.sh
themarpe
approved these changes
Jan 17, 2022
Collaborator
themarpe
left a comment
themarpe
left a comment
There was a problem hiding this comment.
LGTM if works as intended.
(Note, the check isn't important IMO - if its already installed, it wont reinstall)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.