Skip to content

add compressed_payload field to both RpcRequest and RpcResponse #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xianshijing-lk wants to merge 2 commits into
base: main
Choose a base branch
from
+37 −4
Open

add compressed_payload field to both RpcRequest and RpcResponse #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc693da
add compressed_payload field to both RpcRequest and RpcResponse
xianshijing-lk Feb 6, 2026
840ee54
generated protobuf
github-actions[bot] Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions protobufs/livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,8 @@ message RpcRequest {
string payload = 3;
uint32 response_timeout_ms = 4;
uint32 version = 5;
// Compressed payload data. When set, this field is used instead of `payload`.
bytes compressed_payload = 6;
Copy link
Contributor

@boks1971 boks1971 Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is an alternative a possible consideration? A field like

enum Encoding {
     BASE64 = 0;   --> to ensure default remains the same
     COMPRESSION_TYPE_1 = 1; 
     COMPRESSION_TYPE_2 = 2;
}

This allows an extensible format and we can have any encoding.

Copy link
Contributor

@lukasIO lukasIO Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this suggestion

}

message RpcAck {
Expand All @@ -468,6 +470,8 @@ message RpcResponse {
oneof value {
string payload = 2;
RpcError error = 3;
// Compressed payload data. When set, this field is used instead of `payload`.
bytes compressed_payload = 4;
}
}

Expand Down