-
Notifications
You must be signed in to change notification settings - Fork 124
add compressed_payload field to both RpcRequest and RpcResponse #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| uint32 response_timeout_ms = 4; | ||
| uint32 version = 5; | ||
| // Compressed payload data. When set, this field is used instead of `payload`. | ||
| bytes compressed_payload = 6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an alternative a possible consideration? A field like
enum Encoding {
BASE64 = 0; --> to ensure default remains the same
COMPRESSION_TYPE_1 = 1;
COMPRESSION_TYPE_2 = 2;
}
This allows an extensible format and we can have any encoding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this suggestion
|
A gentle ping, what do you think about the comment ? I am open to adding an enum, but would like to get confirmation we want to do it with this PR now |
Not sure who you were addressing to @xianshijing-lk . I think an enum in this PR would be great. Doing one version with |
So that we don't need to use base64 to encode the string, which adds 33% of overhead