Skip to content

fix: Improve fallback behavior when using custom data system configuration #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Improve fallback behavior when using custom data system configuration #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ldclient/impl/datasystem/fdv2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,20 +656,12 @@ def _recovery_condition(self, status: DataSourceStatus) -> bool:
:param status: Current data source status
:return: True if recovery condition is met
"""
interrupted_at_runtime = (
status.state == DataSourceState.INTERRUPTED
and time.time() - status.since > 60 # 1 minute
)
healthy_for_too_long = (
status.state == DataSourceState.VALID
and time.time() - status.since > 300 # 5 minutes
)
cannot_initialize = (
status.state == DataSourceState.INITIALIZING
and time.time() - status.since > 10 # 10 seconds
)

return interrupted_at_runtime or healthy_for_too_long or cannot_initialize
return healthy_for_too_long

def _persistent_store_outage_recovery(self, data_store_status: DataStoreStatus):
"""
Expand Down
Loading