fix: Improve fallback behavior when using custom data system configuration#407
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: Improve fallback behavior when using custom data system configuration#407devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
…ation Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keelerm84
approved these changes
Feb 17, 2026
tanderson-ld
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Ports the same fix from the Go SDK: launchdarkly/go-server-sdk#348
Describe the solution you've provided
Removes the
interrupted_at_runtimeandcannot_initializeconditions from_recovery_conditionin the FDv2 data system. Recovery (jumping back to the first/preferred synchronizer) now only triggers when the current non-primary synchronizer has beenVALIDfor more than 5 minutes.The removed conditions could cause premature recovery attempts that interfere with data system configurations using more than two synchronizers. The
_fallback_condition(which moves forward through synchronizers) is unchanged and still uses bothinterrupted_at_runtimeandcannot_initialize.Human review checklist
_fallback_conditionat line 632) is intentionally left as-isAdditional context
Link to Devin run | Requested by @keelerm84
Note
Medium Risk
Changes FDv2 synchronizer switching logic, which can affect availability and how multi-synchronizer configurations behave during outages. Risk is moderate due to potential impact on failover/recovery timing, though the change is small and localized.
Overview
FDv2’s recovery behavior when running on a non-primary synchronizer is tightened so it only switches back to the preferred (index 0) synchronizer after the current one has been
VALIDfor more than 5 minutes.This removes recovery triggers based on being
INTERRUPTEDfor 1 minute or stuckINITIALIZINGfor 10 seconds, reducing premature “jump back” behavior in configurations with multiple synchronizers; the forward fallback logic in_fallback_conditionremains unchanged.Written by Cursor Bugbot for commit 82cd8e6. This will update automatically on new commits. Configure here.