fix: change calculation from fy to match square pixel assumption#200
Open
ahamboeck wants to merge 1 commit intoisaac-sim:mainfrom
Open
fix: change calculation from fy to match square pixel assumption#200ahamboeck wants to merge 1 commit intoisaac-sim:mainfrom
ahamboeck wants to merge 1 commit intoisaac-sim:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align camera_info intrinsics with depth → point cloud (square pixels assumption)
Summary
This PR updates the fy calculation in
camera_info_utils.pyso that it matches the depth → point cloud implementation (OgnIsaacConvertDepthToPointCloud.cpp).Previously,
camera_info_utils.pycalculated fy using the vertical aperture:But in depth → point cloud, fy was already implemented as:
This simplifies to:
which makes fy the same as fx.
With this PR,
camera_info_utils.pynow uses the same formula as the depth → point cloud path, enforcing the square pixel assumption consistently.Why
Recommendation
References