-
Notifications
You must be signed in to change notification settings - Fork 10
[minor] add the support for path based routing in the gitops #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6196e19
add routing mode properties in the suite
2b0652f
update the routing mode variable
8974b09
update the routing variable names
ed296c2
add the require vars in the suite
f22f5b0
Merge branch 'main' into ds.path
dixitgsathwara c495c85
Merge branch 'main' into ds.path
dixitgsathwara 229cbe3
Update routing configuration keys in values.yaml
dixitgsathwara 65948d4
Fix comment for ingress_controller_name configuration
dixitgsathwara 7cc5a50
add the if condition block for the routing mode
9d3e3ee
update the commit message
6195657
Merge branch 'main' into ds.path
dixitgsathwara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,10 @@ | ||
| --- | ||
| instance_id: xxx | ||
| ibm_entitlement_key: xxxx | ||
|
|
||
| # Network Routing Configuration (Only for MAS channel 9.2 and onwards) | ||
| # Options: "path" or "subdomain" (default: subdomain) | ||
| # routing_mode: path | ||
|
|
||
| # IngressController name (required when routing_mode is "path") | ||
| # ingress_controller_name: default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.