Conversation
whitfiea
requested changes
Mar 2, 2026
| {{ .Values.suite_spec_settings_additional_properties | toYaml | indent 4 }} | ||
| {{- end }} | ||
| manualCertMgmt: {{ .Values.mas_manual_cert_mgmt | default false }} | ||
| routingMode: {{ .Values.routing_mode | default "subdomain" }} |
Member
There was a problem hiding this comment.
Can we add this in an if condition like the ingressControllerName? Then if this is 9.0 or 9.1 then we won't set it, we don't need to set the default then. I asume that in 9.2 if it is not set at all then it default to subdomain still?
Contributor
Author
There was a problem hiding this comment.
yes, in MAS 9.2, if routing mode is not set then it defaults to subdomain. this default routing mode is configured in the saas-envs-starter (where MAS_ROUTING_MODE set during environment setup), and then this value is added to the mas-instance-params.yaml file.
root-applications/ibm-mas-instance-root/templates/130-ibm-mas-suite-app.yaml
Show resolved
Hide resolved
whitfiea
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira Issue
Testing