Skip to content

Improve the debugging experience#6

Merged
Juliaj merged 4 commits intomainfrom
jj/fix/debug_file_not_found_new
Mar 3, 2026
Merged

Improve the debugging experience#6
Juliaj merged 4 commits intomainfrom
jj/fix/debug_file_not_found_new

Conversation

@Juliaj
Copy link

@Juliaj Juliaj commented Mar 3, 2026

Main changes

  • Introduces a debug task to check webcam and serial port, pixi run check-devices.
  • Adds a dataflow file to run Demo for team_krishan.

@kbhakt,

I couldn't repro the issue on my Windows machine. Can you run following command? If you still see errors, copy/paste the output for me. Please check Demo/dataflow_tracking_real_team_krishan.yml before running following steps.

# From git bash terminal, run following, fix any errors reported. See the output from my machine at the end.
pixi run check-devices

# Run following from the project root, i.e. outside Demo folder
pixi run dora build Demo/dataflow_tracking_real_team_krishan.yml   # once

# When running following, check whether you see following line from the console log
# hand_controller: stdout    Opening "../config/calibration/l_hand_team_krishan.toml"
pixi run dora run Demo/dataflow_tracking_real_team_krishan.yml

pixi run check-devices output following on my machine

=== AmazingHand device check ===                                                                                                                                                 

Webcam indices:
  0: 640x480
  Use index 0 in HandTracking unless you have multiple cameras.

Serial ports:
  COM3: USB-Enhanced-SERIAL CH343 (COM3) (USB, likely hand)
  Use the USB device in dataflow YAML --serialport.

@Juliaj Juliaj mentioned this pull request Mar 3, 2026
@Juliaj Juliaj requested a review from kbhakt March 3, 2026 07:21
@kbhakt
Copy link

kbhakt commented Mar 3, 2026

Thanks for adjusting the PR. I have no preference on naming of branches -- what is good practice?

I've seen things like "feature/..." or "bug_fix/..."? What is good software practice?

Output on pixi run check-devices is same as above in the README.

Everything is working now. Seemed like rebuilding fixed it. Maybe I messed up how I installed previously...

Sent you a video over text.

@Juliaj
Copy link
Author

Juliaj commented Mar 3, 2026

I have no preference on naming of branches -- what is good practice?

I don’t have a strong preference on branch names either. Common patterns:

  • committer_initial/{feat|fix|refactor|ci}/short-description(e.g. jj/fix/debug_file_not_found)
  • type/short-description (e.g. feat/amazinghand-sdk)
  • issue-number-short-description (e.g. 42-add-sdk)

I’d lean toward: committer_initial/{feat|fix|refactor|ci}/desc. It keeps branches grouped by author and type.
We could also add the type prefix to PR titles (e.g. feat: Add amazinghand SDK) so the type is visible in the PR list.

@Juliaj Juliaj merged commit 680c1f3 into main Mar 3, 2026
2 checks passed
@Juliaj Juliaj deleted the jj/fix/debug_file_not_found_new branch March 3, 2026 17:59
@Juliaj
Copy link
Author

Juliaj commented Mar 3, 2026

@kbhakt, just FYI, FORK.md lists the diffs from upstream.

@kbhakt
Copy link

kbhakt commented Mar 5, 2026

sounds good -- will try this format out next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants