Conversation
|
Hey, before I merge this I want to try and take all the logic out to a function and add a unit test, this area has been getting lots of attention and testing it is a little complex, I think. unit test would help out. so didn't forget it yet |
|
Ok, I put that section of code in to a unit test. # aarch64 host
# ["aarch64:armv7l:gentoo"]="not using qemu"
["aarch64:armv7l:ubuntu"]="using qemu-arm-static"
# ["aarch64:armhf:gentoo"]="not using qemu"
["aarch64:armhf:ubuntu"]="using qemu-arm-static"
["aarch64:aarch64:gentoo"]="not using qemu"
["aarch64:aarch64:ubuntu"]="not using qemu"
["aarch64:arm64:gentoo"]="not using qemu"
["aarch64:arm64:ubuntu"]="not using qemu"
What target are you trying to build to on aarch64? And what distribution (if docker then its debian/Ubuntu)? |
|
I'm not sure I'm fully understanding what you're trying to do. However I've tested my code changes on both aarch64 and amd64 generating aarch64 PI images. No Docker. |
|
What I am doing is adding a unit test. It takes the code in the What its saying is that you need is to source the Here is the execution order documentation: What this PR is suggesting is: |
|
Without my patch, |
|
Hey, And it tests a bunch of scenarios and the expected output. I then re-implemented this PR with the new function: So I am planning to merge that here: What I have left is to factor in what this change does and append it to test test matrix here: https://github.com/guysoft/CustomPiOS/blob/feature/unit-testing/tests/test_qemu_setup.sh#L42 |
That test block is here: Should not use qemu, not sure why the test seems to pass without this fix. It passes in both cases so it should be ok to merge. But I am not sure why it passes |
|
I'm on a Debain 11 system running aarch64: These tests don't match what you showed. Here's my output: |
|
Was was NOT having my patch applied. |
|
Sorry this is the PR with your patch: |
|
Merged here: |
This pull request addresses two things: