fix: read BASE_BOARD from config before generate EXTRA_BOARD_CONFIG#247
Open
meteyou wants to merge 1 commit intoguysoft:develfrom
Open
fix: read BASE_BOARD from config before generate EXTRA_BOARD_CONFIG#247meteyou wants to merge 1 commit intoguysoft:develfrom
meteyou wants to merge 1 commit intoguysoft:develfrom
Conversation
Owner
Owner
|
Getting with this Need to investigate more. Looks like its picking up the config file in CustomPiOS and not the config file in the distribution file |
Owner
|
Nope, on second thought #240 is better, its importing the correct distro config path and not custompios path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the generate
EXTRA_BOARD_CONFIG, because this was generated before CustomPiOS reads the config file. This is needed to build images which are not armhf, becausegenerate_board_config.pyhas a fallback to raspberrypi os 32 bit with armhf, this override theBASE_ARCHwith theEXTRA_BOARD_CONFIG.This PR is based of the discussion from #240 and fixes #239