fixed bug for windows-arm64 (introduced in pull request #291)#353
Open
NicSavichev wants to merge 1 commit intogoogle:mainfrom
Open
fixed bug for windows-arm64 (introduced in pull request #291)#353NicSavichev wants to merge 1 commit intogoogle:mainfrom
NicSavichev wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
@NicSavichev, When this patch was added, there was no common INTROSPECTION_TABLE yet and table was sync with linux implementation, could you try to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#291 introduced shorter INTROSPECTION_TABLE in impl_aarch64_windows.c so while public headers declare AARCH64_LAST_=78 only 54 entries were inited in kGetters kFeatureNames.
Thus iterating all features upto AARCH64_LAST_ caused crash as long as garbage pointer at kGetters[54] was called.
Current implementation seems very unsafe and in order to prevent crash we should check for kGetters array size (that corresponds to INTROSPECTION_TABLE entries). Another solution is static assert for AARCH64_LAST_ == sizeof(kGetters).