Open
Conversation
Contributor
Author
|
@gchatelet, @Mizux, PR is ready to review |
Mizux
reviewed
May 19, 2025
| @@ -0,0 +1,26 @@ | |||
| # ref: https://github.com/actions/runner-images | |||
Collaborator
There was a problem hiding this comment.
to replace by this url https://github.com/actions/partner-runner-images
Mizux
reviewed
May 19, 2025
| pull_request: | ||
| schedule: | ||
| # min hours day(month) month day(week) | ||
| - cron: '0 0 7,22 * *' |
Collaborator
There was a problem hiding this comment.
can we add workflow_dispatch: too to be able to run it manually ?
Mizux
reviewed
May 19, 2025
|
|
||
| jobs: | ||
| # Building using the github runner environement directly. | ||
| make: |
Collaborator
|
I think on windows most features flag are not populated.... cpu_features/test/cpuinfo_aarch64_test.cc Lines 126 to 137 in d3b2440 cf: vs https://github.com/google/cpu_features/blob/main/src/impl_aarch64_windows.c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github actions added support Windows Arm64 for public repositories with runner name
windows-11-arm:Cmake has known issue related to build for Windows Arm64.
CMAKE_SYSTEM_PROCESSORon Arm64 target showsAMD64...Issue discussion:
So
CMAKE_<LANG>_COMPILER_ARCHITECTURE_IDmust be used to setPROCESSOR_IS_AARCH64architecture:Also, currently we have build fail for windows Arm64, I think it should be fixed as separate patch:
LINEfeatures from src/impl_aarch64__base_implementation.inl#L31We can't use "define_introspection_and_hwcaps.inl" as a common file for all operating systems due to msvc compiler error C2099: initializer is not a constant, so as a workaround for Windows I used separate "define_introspection.inl"