Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/publishnuget.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ jobs:
run: dotnet test --no-restore --verbosity normal
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dotnet test step uses --no-restore but not --no-build or --configuration Release, so it will rebuild (defaulting to Debug) and won’t actually test the Release build produced in the previous step. Consider aligning with .github/workflows/test.yml by using dotnet test --no-build --configuration Release (and keep --verbosity normal if desired) to avoid redundant builds and ensure Release artifacts are validated.

This issue also appears on line 35 of the same file.

Suggested change
run: dotnet test --no-restore --verbosity normal
run: dotnet test --no-build --configuration Release --no-restore --verbosity normal

Copilot uses AI. Check for mistakes.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot - this branch has already been merged, but implement these proposed changes as a new PR against main - also do a second pass of a code review for additional issues.

- name: Build
run: dotnet pack --no-restore StreamRegex.Extensions -o NuPkgs
- name: Setup NuGet.exe for use with actions
uses: NuGet/setup-nuget@v1.0.5
with:
nuget-api-key: ${{secrets.NUGET_API_KEY}}
- name: Nuget Publish
run: nuget push NuPkgs/*.*nupkg -Source https://api.nuget.org/v3/index.json
- name: NuGet Publish
run: dotnet nuget push NuPkgs/*.nupkg --api-key "$NUGET_API_KEY" --source https://api.nuget.org/v3/index.json --skip-duplicate
env:
NUGET_API_KEY: ${{secrets.NUGET_API_KEY}}
Loading