Conversation
Co-authored-by: gfs <98900+gfs@users.noreply.github.com>
Co-authored-by: gfs <98900+gfs@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the NuGet publishing GitHub Actions workflow to work on ubuntu-latest runners by switching from nuget.exe to the cross-platform dotnet nuget push.
Changes:
- Remove
NuGet/setup-nugetand publish usingdotnet nuget push - Provide NuGet API key via an environment variable
- Add
--skip-duplicateto make re-publishes idempotent
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: gfs <98900+gfs@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/publishnuget.yml:36
dotnet packis invoked without--configuration Release(defaults to Debug) and without--no-build, so it will rebuild and may produce/publish a Debug-config NuGet package. Consider usingdotnet pack --no-build --configuration Release ...(and rely on the earlier Release build) to ensure the published package matches the intended configuration and to reduce CI time.
- name: Build
run: dotnet pack --no-restore StreamRegex.Extensions -o NuPkgs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -34,9 +34,7 @@ jobs: | |||
| run: dotnet test --no-restore --verbosity normal | |||
There was a problem hiding this comment.
The dotnet test step uses --no-restore but not --no-build or --configuration Release, so it will rebuild (defaulting to Debug) and won’t actually test the Release build produced in the previous step. Consider aligning with .github/workflows/test.yml by using dotnet test --no-build --configuration Release (and keep --verbosity normal if desired) to avoid redundant builds and ensure Release artifacts are validated.
This issue also appears on line 35 of the same file.
| run: dotnet test --no-restore --verbosity normal | |
| run: dotnet test --no-build --configuration Release --no-restore --verbosity normal |
There was a problem hiding this comment.
@copilot - this branch has already been merged, but implement these proposed changes as a new PR against main - also do a second pass of a code review for additional issues.
Fix GitHub Actions workflow build failure
nuget.execannot run on Linux (ubuntu-latest runner)NuGet/setup-nugetaction withdotnet nuget pushcommandOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.