Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
- Bump Android SDK from v8.32.0 to v8.33.0 ([#5684](https://github.com/getsentry/sentry-react-native/pull/5684))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8330)
- [diff](https://github.com/getsentry/sentry-java/compare/8.32.0...8.33.0)
- Bump Android SDK Stubs from v8.32.0 to v8.33.0 ([#5697](https://github.com/getsentry/sentry-react-native/pull/5697))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8330)
- [diff](https://github.com/getsentry/sentry-java/compare/8.32.0...8.33.0)
Comment on lines +16 to +18
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The replay-stubs.jar file appears to be missing from this PR, despite the version bump. The project's README requires this file to be regenerated and committed.
Severity: HIGH

Suggested Fix

Run yarn build from the root of the repository to regenerate the replay-stubs.jar file. Verify that the newly generated packages/core/android/libs/replay-stubs.jar is included in the commit.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: CHANGELOG.md#L16-L18

Potential issue: This pull request updates the Android SDK Stubs version to v8.33.0 in
the `CHANGELOG.md`, but does not include the regenerated
`packages/core/android/libs/replay-stubs.jar` file. According to the project's
documentation, this file must be regenerated via `yarn build` and committed after a
version bump. If the underlying Java interfaces, such as `ReplayBreadcrumbConverter`,
have changed in v8.33.0, failing to include the updated JAR could lead to runtime
crashes like `AbstractMethodError` when the replay feature is used.

Did we get this right? 👍 / 👎 to inform future reviews.


## 8.1.0

Expand Down
Loading