chore(deps): update Android SDK Stubs to v8.33.0#5697
Merged
Conversation
bb44437 to
820bdec
Compare
Contributor
Author
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Author
Comment on lines
+16
to
+18
| - Bump Android SDK Stubs from v8.32.0 to v8.33.0 ([#5697](https://github.com/getsentry/sentry-react-native/pull/5697)) | ||
| - [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8330) | ||
| - [diff](https://github.com/getsentry/sentry-java/compare/8.32.0...8.33.0) |
There was a problem hiding this comment.
Bug: The replay-stubs.jar file appears to be missing from this PR, despite the version bump. The project's README requires this file to be regenerated and committed.
Severity: HIGH
Suggested Fix
Run yarn build from the root of the repository to regenerate the replay-stubs.jar file. Verify that the newly generated packages/core/android/libs/replay-stubs.jar is included in the commit.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: CHANGELOG.md#L16-L18
Potential issue: This pull request updates the Android SDK Stubs version to v8.33.0 in
the `CHANGELOG.md`, but does not include the regenerated
`packages/core/android/libs/replay-stubs.jar` file. According to the project's
documentation, this file must be regenerated via `yarn build` and committed after a
version bump. If the underlying Java interfaces, such as `ReplayBreadcrumbConverter`,
have changed in v8.33.0, failing to include the updated JAR could lead to runtime
crashes like `AbstractMethodError` when the replay feature is used.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-android-stubs.sh from 8.32.0 to 8.33.0.
Auto-generated by a dependency updater.
Changelog
8.33.0
Features
installGroupsOverrideparameter to Build Distribution SDK for programmatic filtering, with support for configuration via properties file usingio.sentry.distribution.install-groups-override(#5066)Fixes
SentryExecutorServiceinSentryOptions(#5093)sendDefaultPii(#5099)androidx.camera.view.PreviewViewto defaultmaskedViewClassesto mask camera previews by default. (#5097)Dependencies
Internal
Add integration to track session replay custom masking (#5070)
Add
installGroupsproperty to Build Distribution SDK (#5062)Full CHANGELOG.md diff