Skip to content

[Nexthop] Distro Image build fixes #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
travisb-nexthop wants to merge 2 commits into from
+17 −2
Closed

[Nexthop] Distro Image build fixes #986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d191518
[Nexthop] Distro Image build fixes
travisb-nexthop Feb 26, 2026
b519c0f
Merge remote-tracking branch 'origin/main' into distro_image_build_fixes
travisb-nexthop Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions fboss/oss/scripts/build_fboss_stack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,29 +92,44 @@ if [ "$need_sai" -eq 1 ]; then

if [ -n "${BUILD_SAI_FAKE:-}" ]; then
sai_name="sai-fake"
export BUILD_SAI_FAKE
export BUILD_SAI_FAKE_LINK_TEST
elif [ -n "${SAI_BRCM_IMPL:-}" ]; then
sai_name="sai-bcm-${SAI_SDK_VERSION}"
export SAI_BRCM_IMPL
else
sai_name="sai-unknown-${SAI_SDK_VERSION}"
fi
echo "Using SAI implementation: $sai_name"

if [ -n "${SAI_VERSION:-}" ]; then
export SAI_VERSION
fi
if [ -n "${SAI_SDK_VERSION:-}" ]; then
export SAI_SDK_VERSION
fi
fi

# Use a scratch path for the CMake build tree.
# For forwarding we use /build (host-backed via distro_cli) so caches persist
# across container runs
scratch_root="/build"
if [ "$need_sai" -eq 1 ]; then
common_root="${scratch_root}/forwarding-stack/common"
build_dir="${scratch_root}/forwarding-stack/${sai_name}"
else
common_root="${scratch_root}/platform-stack/common"
build_dir="${scratch_root}/platform-stack"
fi
mkdir -p "$build_dir"

common_root="${scratch_root}/common"

common_options='--allow-system-packages'
common_options+=' --scratch-path '$build_dir
common_options+=' --extra-cmake-defines {'
common_options+='"CMAKE_BUILD_TYPE":"MinSizeRel"'
common_options+=',"CMAKE_CXX_STANDARD":"20"'
common_options+=',"RANGE_V3_TESTS":"OFF"'
common_options+=',"RANGE_V3_PERF":"OFF"}'
common_options+=' --src-dir .'
common_options+=' fboss'

Expand Down
Loading