[Nexthop] Distro Image build fixes#986
Open
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
Build fixes needed for Distro Image. Firstly some additional cmake defines are necessary due to moving to clang. Secondly, though the sai_build.env values are source'd into the build script shell instance, they must also be exported to be made available to the getdeps invocation. Failure to do this results in the FBOSS build using a default set of headers for SAI API 1.16.3 instead of whichever version the SAI specifies. However, build-helper.py still configures the build to use the proper SAI library. This results in mismatched SAI API enum values versus that known to the SAI library; which results in confusing crash errors. This is copied from the Distro Omnibus PR, which successfully builds an image when including these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Build fixes needed for Distro Image.
Firstly some additional cmake defines are necessary due to moving to clang.
Secondly, though the sai_build.env values are source'd into the build script shell instance, they must also be exported to be made available to the getdeps invocation.
Failure to do this results in the FBOSS build using a default set of headers for SAI API 1.16.3 instead of whichever version the SAI specifies. However, build-helper.py still configures the build to use the proper SAI library.
This results in mismatched SAI API enum values versus that known to the SAI library; which results in confusing crash errors.
Test Plan
This is copied from the Distro Omnibus PR, which successfully builds an image when including these changes.