Conversation
AdrianSosic
requested changes
Feb 8, 2024
Collaborator
AdrianSosic
left a comment
AdrianSosic
left a comment
There was a problem hiding this comment.
Hi @AVHopp, @Scienfitz. I've changed the file quite drastically. Please have a look if you like it. The structure and logic remains the same but:
- I significantly shortened text
- Added more structuring elements (like bullets, notes)
- Added links everywhere
- Made the code more pythonic / condensed
- Regrouped a few things
AVHopp
commented
Feb 8, 2024
AVHopp
commented
Feb 8, 2024
AVHopp
commented
Feb 8, 2024
AVHopp
commented
Feb 8, 2024
AVHopp
commented
Feb 8, 2024
Collaborator
Author
There was a problem hiding this comment.
First: Appreciate your work @AdrianSosic, especially the improvements of the code :)
But: The style of this example is now quite different from our other examples, and some parts (like the note) feel more like something that belongs to a user guide, and not an example. See my corresponding individual comments.
AdrianSosic
force-pushed
the
docs/basic_tl_example
branch
from
351a472 to
13e3cfc
Compare
AdrianSosic
reviewed
Feb 12, 2024
AdrianSosic
reviewed
Feb 14, 2024
AVHopp
force-pushed
the
docs/basic_tl_example
branch
from
a3ac6d6 to
7ec3c31
Compare
AVHopp
commented
Feb 19, 2024
Scienfitz
reviewed
Feb 20, 2024
Collaborator
Scienfitz
left a comment
Scienfitz
left a comment
There was a problem hiding this comment.
minor things, example is basically gucci
Scienfitz
reviewed
Feb 20, 2024
|
|
AVHopp
force-pushed
the
docs/basic_tl_example
branch
from
31bbda8 to
860a990
Compare
Scienfitz
approved these changes
Feb 23, 2024
Collaborator
Scienfitz
left a comment
Scienfitz
left a comment
There was a problem hiding this comment.
thanks for sticking with this!
AVHopp
force-pushed
the
docs/basic_tl_example
branch
from
860a990 to
3891daa
Compare
This was referenced Feb 23, 2024
AVHopp
force-pushed
the
docs/basic_tl_example
branch
from
3891daa to
03d89e0
Compare
* Make it more pythonic * Add missing BATCH_SIZE constant * Improve grouping of parts that belong together
* Shorten it * Add links * Add structure (notes and bullets)
AVHopp
force-pushed
the
docs/basic_tl_example
branch
from
03d89e0 to
3946812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic Transfer Learning example, including the SMOKE_TEST functionality and the multi-version plotting.
This branch is currently based on the corresponding branch that implements SMOKE_TEST and multi-version plotting. ONly the last 3 commits are actually relevant.
Note that this PR also makes typos ignore .svg files, since these should definitely not be checked for typos.