Skip to content

Added a time out for the market data semaphore in the client #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewdicks98 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a time out for the market data semaphore in the client #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ClientSimulator/src/main/java/client/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,15 @@ public void close() {
System.out.println("Logged out.");
}

public void waitForMarketDataUpdate() { while(!mktDataUpdateSemaphore.acquire()){} }
public void waitForMarketDataUpdate() {
long startTime = System.currentTimeMillis();
while(!mktDataUpdateSemaphore.acquire()){
Copy link
Owner

@dharmeshsing dharmeshsing May 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acquire is a blocking operation. This should be tryAcquire with a timeout

Copy link
Author

@matthewdicks98 matthewdicks98 May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. This was the implementation in the Hawkes client so does that need to be changed to use a tryAquire as well?

if(System.currentTimeMillis() - startTime > 100_000){
System.out.println("Market Data Time out");
break;
}
}
}

public void submitOrder(String clientOrderId, long volume, long price, String side, String orderType, String timeInForce, long displayQuantity, long minQuantity, long stopPrice) {
mktDataUpdateSemaphore.acquire();
Expand Down