Added a time out for the market data semaphore in the client

[matthewdicks98]

Added a time out for the semaphore in the client using the same structure as found in the Hawkes client.

[dharmeshsing]

acquire is a blocking operation. This should be tryAcquire with a timeout

[matthewdicks98]

No problem. This was the implementation in the Hawkes client so does that need to be changed to use a tryAquire as well?

[dharmeshsing]

I don’t recall why the code was written like that, so I think it is best to make the change on your code first before updating the hawkes client code.

…

On 16 May 2022, at 4:14 pm, matthewdicks98 ***@***.***> wrote: @matthewdicks98 commented on this pull request. In ClientSimulator/src/main/java/client/Client.java <#8 (comment)>: > @@ -153,7 +153,15 @@ public void close() { System.out.println("Logged out."); } - public void waitForMarketDataUpdate() { while(!mktDataUpdateSemaphore.acquire()){} } + public void waitForMarketDataUpdate() { + long startTime = System.currentTimeMillis(); + while(!mktDataUpdateSemaphore.acquire()){ No problem. This was the implementation in the Hawkes client so does that need to be changed to use a tryAquire as well? — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACSXZWLUBP65NQDLFERKWPLVKHRTDANCNFSM5VYAOY2A>. You are receiving this because you commented.