Address issue #354 and update project settings to recommended ones per Xcode 26#355
Draft
alexanderdibenedetto wants to merge 4 commits intomasterfrom
Draft
Conversation
added 4 commits
February 17, 2026 16:25
| #import <TrustKit/TSKPinningValidatorResult.h> | ||
| #import <TrustKit/TSKPinningValidatorCallback.h> | ||
| #import <TrustKit/TSKPinningValidator.h> | ||
| #import <TrustKit/TSKTrustDecision.h> |
Comment on lines
-1649
to
+1657
| MACOSX_DEPLOYMENT_TARGET = 10.13; | ||
| MACOSX_DEPLOYMENT_TARGET = 11.0; |
There was a problem hiding this comment.
Are we intentionally dropping those old macOS versions?
Author
There was a problem hiding this comment.
Interestingly, macOSX 11 was overridden in the TrustKit OS X target to be 11.0 (but not changed in the project level settings). This updates it at the project level and removes it from being overridden in the target settings.
| @"www.datatheorem.com" : @{ | ||
| kTSKEnforcePinning : @YES, | ||
| kTSKPublicKeyHashes : @[@"F6jTih9VkkYZS8yuYqeU/4DUGehJ+niBGkkQ1yg8H3U=", // CA key | ||
| kTSKPublicKeyHashes : @[@"OdSlmQD9NWJh4EbcOHBxkhygPwNSwA9Q91eounfbcoE=", // CA key |
There was a problem hiding this comment.
Why was this changed?
Edit: new cert?
Author
There was a problem hiding this comment.
Yes - the test failed....because the cert was the old one!
EthanArbuckle
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves as a maintenance update to this project ahead of fixing other issues.