MooseX::POE also provides strict and warnings

[simbabque]

This is part of my entry for the Pull Request Challenge in 2017 towards the dist semifor/twirc. This commit fixes a Kwalitee issue in one of the modules inside that dist, which is in fact not an issue at all.

[charsbar]

Thanks for the PR. I understand your point but I have not yet decided if this should be merged, because MooseX::POE doesn't explicitly explain in the pod that it loads strict and warnings into caller's namespace, and the code is not so obvious about that.

[simbabque]

I felt the same way. What I did to check was actually try it out with the SYNOPSIS of MooseX::POE.

$ cat test.pl

package Counter;
use MooseX::POE;

has count => (
    isa     => 'Int',
    is      => 'rw',
    lazy    => 1,
    default => sub { 0 },
);

sub START {
    my ($self) = @_;
    $self->yield('increment');
}

event increment => sub {
    my ($self) = @_;
    print "Count is now " . $self->count . "\n";
    $self->count( $self->count + 1 );
    $self->yield('increment') unless $self->count > 3;
};

no MooseX::POE;

Counter->new();
POE::Kernel->run();

I then run this through B::Deparse.

$ perl -MO=Deparse test.pl
package Counter;
sub BEGIN {
    require MooseX::POE;
    do {
        'MooseX::POE'->import
    };
}
use warnings;
use strict;
has('count', ('isa', 'Int', 'is', 'rw', 'lazy', 1, 'default', sub {
    0;
}
));
sub START {
    my($self) = @_;
    $self->yield('increment');
}
event('increment', sub {
    my($self) = @_;
    print 'Count is now ' . $self->count . "\n";
    $self->count($self->count + 1);
    $self->yield('increment') unless $self->count > 3;
}
);
no MooseX::POE;
'Counter'->new;
'POE::Kernel'->run;
test.pl syntax OK

As you can see, there's a use strict and use warnings there, so I assumed that was imported via Moose.

Removing one of the my keywords from that code will result in errors, which is another indicator that strict is on.

I tested that on 5.20.1. Let me see if I have an older one laying around.

[karenetheridge]

strict and warnings are coming from this line in MooseX::POE:

my ( $import, $unimport, $init_meta ) = Moose::Exporter->setup_import_methods(
    with_caller     => [qw(event)],
    also            => 'Moose',        # <-- this line
    ...