Skip to content

crate_universe: Fix workspace root detection #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phlax wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

crate_universe: Fix workspace root detection #3813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crate_universe/extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ def _generate_hub_and_spokes(
)

# The workspace root when one is explicitly provided.
nonhermetic_root_bazel_workspace_dir = module_ctx.path(Label("@@//:MODULE.bazel")).dirname
nonhermetic_root_bazel_workspace_dir = module_ctx.path(Label("@@//:BUILD")).dirname
Copy link
Collaborator

@UebelAndre UebelAndre Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most repositories I interact with use BUILD.bazel as the file name, I think this is going to be less consistent for folks.


# If re-pinning is enabled, gather additional inputs for the generator
kwargs = dict()
Expand Down