crate_universe: Fix workspace root detection#3813
Open
phlax wants to merge 1 commit intobazelbuild:mainfrom
Open
crate_universe: Fix workspace root detection#3813phlax wants to merge 1 commit intobazelbuild:mainfrom
phlax wants to merge 1 commit intobazelbuild:mainfrom
Conversation
without this, updating the crate triggers a reanalysis, causing recursion and the task to recurse, spin out, hang and fail Signed-off-by: Ryan Northey <ryan@synca.io>
This was referenced Jan 21, 2026
UebelAndre
requested changes
Feb 28, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Sorry about the delay here! Can you tell me about the root cause of the issue here? Like what triggers the recursion?
|
|
||
| # The workspace root when one is explicitly provided. | ||
| nonhermetic_root_bazel_workspace_dir = module_ctx.path(Label("@@//:MODULE.bazel")).dirname | ||
| nonhermetic_root_bazel_workspace_dir = module_ctx.path(Label("@@//:BUILD")).dirname |
Collaborator
There was a problem hiding this comment.
Most repositories I interact with use BUILD.bazel as the file name, I think this is going to be less consistent for folks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this, updating the crate triggers a reanalysis, causing recursion and the task to spin out, hang and fail