Fix isolation of login flows when Using Multiple AuthProvider Instances#327
Open
kavindadimuthu wants to merge 3 commits intoasgardeo:mainfrom
Open
Fix isolation of login flows when Using Multiple AuthProvider Instances#327kavindadimuthu wants to merge 3 commits intoasgardeo:mainfrom
kavindadimuthu wants to merge 3 commits intoasgardeo:mainfrom
Conversation
kavindadimuthu
force-pushed
the
fix/provider-login-race
branch
from
f3b7233 to
2e893ab
Compare
brionmario
previously approved these changes
Feb 3, 2026
| authRequestConfig['client_secret'] = configData.clientSecret; | ||
| } | ||
|
|
||
| authRequestConfig['state'] = 'instance_' + this.getInstanceId() + '-' + configData.clientId; |
Contributor
There was a problem hiding this comment.
Is it better to include this in a separate variable? @brionmario
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fix the isolation of login flows when Using Multiple AuthProvider Instances. The changes ensure that authentication flows and storage are correctly scoped to each instance, preventing conflicts when multiple auth clients are used in the same application. The update also adds utilities to detect if the current URL is intended for a specific instance.
Key changes include:
Multi-auth instance support in authClient:
AsgardeoAuthClientto use an instance property forinstanceIDinstead of a static class property, ensuring each client instance is independent. Storage keys and state parameters now include the correctinstanceId. [1] [2] [3] [4]URL utilities and authentication flow:
hasCalledForThisInstanceInUrlutility to check if the current URL'sstateparameter matches the expected instance, and exported it from the browser SDK. [1] [2]useBrowserUrlReact hook andAsgardeoProviderto use the new utility, ensuring authentication callbacks are processed only by the correct client instance. [1] [2] [3] [4] [5]Related Issues
Related PRs
Checklist
Security checks