Fix failure of calling authenticated APIs from secondary AsgardeoProvider Instances (Multi-Provider Support)#337
Open
kavindadimuthu wants to merge 5 commits intoasgardeo:mainfrom
Open
Conversation
…agnization support
kavindadimuthu
force-pushed
the
fix/multi-http-clients
branch
from
d3e913b to
0744686
Compare
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
| private static isHandlerEnabled: boolean; | ||
| private static instances: Map<number, HttpClientInstance> = new Map(); | ||
| private static clientInstances: Map<number, HttpClient> = new Map(); | ||
| private isHandlerEnabled: boolean = true; |
Contributor
There was a problem hiding this comment.
Better not to set a default value without checking the actual usage of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces multi-HTTP clients support when multiple provider instances are implemented. This ensures that all authenticated HTTP operations are isolated per instance.
The most important changes are:
Instance-specific HTTP Client Management
HttpClientto support multiple isolated HTTP client/axios instances, each keyed by instance ID, preventing state conflicts between auth contexts. All HTTP handler flags and callbacks are now instance-specific. [1] [2] [3] [4] [5] [6] [7] [8]HttpClient.getInstance()to provide the correct instance ID, ensuring HTTP requests are routed through the correct context. [1] [2] [3] [4]Related Issues
Related PRs
Checklist
Security checks