Add support for and start testing against Ruby 4#434
Open
larouxn wants to merge 2 commits intoShopify:mainfrom
Open
Add support for and start testing against Ruby 4#434larouxn wants to merge 2 commits intoShopify:mainfrom
larouxn wants to merge 2 commits intoShopify:mainfrom
Conversation
1 task
This was referenced Feb 18, 2026
- Add no-longer-stanadard-library gems to Gemfile and Gemspec - Upgrade gems to versions that support Ruby 4 - Add Ruby 4 to CI matrix - Bump dev Ruby from 3.4.8 to 4.0.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add support for and start testing against Ruby 4.
Requires
What approach did you choose and why?
Taken a multi-step approach as can be seen by my various PRs.
.ruby-versionto4.0.1.bundle exec rakeand confirm everything looks alright.Note, for step 1 above I followed the logs (below) that noted various gems as no-longer-standard-library. Specifically added the development gems (irb and benchmark) to the Gemfile and the production gems (logger and ostruct) to the Gemspec. Note, we don't need to add
relineif we upgradepry-byebugto latest in this PR.Logs showing required gems
relinebenchmarkostructloggerNote
The one gem I'm not sure what to do with yet is
activesupport. While the following (logs below) won't break anything it'd be nice to fix such. The CGI warning is was lead me to bumpi18n. Foractivesupportwe should really be looking at getting on latest v8.1.2. v7.1.x is EOL too.What should reviewers focus on?
Ideally the prerequisite PRs first as I'd like to merge this as just the Ruby 4 specific changes.
The impact of these changes
We support Ruby 4.
Testing
bundle exec rake, please note that thephonelibfrozen string warnings will be fixed by #366.Checklist
Determined necessary as it's a pretty big change to add support for a new Ruby version.