Add in-use Ruby 4.0 non-standard gems to Gemfile/Gemspec#363
Closed
larouxn wants to merge 1 commit intoShopify:mainfrom
Closed
Add in-use Ruby 4.0 non-standard gems to Gemfile/Gemspec#363larouxn wants to merge 1 commit intoShopify:mainfrom
larouxn wants to merge 1 commit intoShopify:mainfrom
Conversation
1 task
1eb899c to
deffa3e
Compare
d387390 to
b7cb54e
Compare
e189642 to
9a7844f
Compare
9a7844f to
ec6498a
Compare
f3bcd94 to
e49b10e
Compare
e49b10e to
1a322cd
Compare
1a322cd to
4fbe7be
Compare
4fbe7be to
5b974cc
Compare
f5654cf to
769faba
Compare
769faba to
7c6af3f
Compare
6ce6732 to
a5a0f3e
Compare
a5a0f3e to
0ef57a5
Compare
0ef57a5 to
9e451bc
Compare
9e451bc to
f573c4d
Compare
Contributor
Author
|
Closing in favour of doing the full Ruby 4 support upgrade in #434. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add gems we use that are no longer included by default in Ruby 4.0 to the Gemfile/Gemspec.
Follow up to #359What approach did you choose and why?
I followed the logs (below) that noted these 4 gems as no-longer-standard-library and added the development gems (irb and benchmark) to the Gemfile and the production gems (logger and ostruct) to the Gemspec.
Note, we don't need to add
relineif we upgradepry-byebugto latest. Have done so in Ruby 4 PR.Logs showing required gems
relinebenchmarkostructloggerWhat should reviewers focus on?
Any issue with the placement of the given gems re: Gemspec versus Gemfile?
The impact of these changes
Cleaner development experience re: no more console warnings re: these gems.
Testing
Checklist
Determined not necessary as it's a developer facing change, not user facing.