Skip to content

Fix example_city and example_city_zip non-nil tests so they actually assert such #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larouxn wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Fix example_city and example_city_zip non-nil tests so they actually assert such #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions test/worldwide/region_yml_consistency_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,14 +485,22 @@ class RegionYmlConsistencyTest < ActiveSupport::TestCase
end

test "example_city is available for each US state" do
assert_predicate Worldwide.region(code: "US").zones, :all? do |state|
!state.example_city&.empty?
Worldwide.region(code: "US").zones.each do |state|
# Skip territories that legitimately don't have cities
next if state.iso_code == "UM" # United States Minor Outlying Islands

assert_kind_of String, state.example_city, "example_city should be a String for #{state.iso_code}"
refute_predicate state.example_city, :empty?, "example_city should not be empty for #{state.iso_code}"
end
end

test "example_city_zip is available for each US state" do
assert_predicate Worldwide.region(code: "US").zones, :all? do |state|
!state.example_city_zip&.empty?
Worldwide.region(code: "US").zones.each do |state|
# Skip territories that legitimately don't have zip codes
next if state.iso_code == "UM" # United States Minor Outlying Islands

assert_kind_of String, state.example_city_zip, "example_city_zip should be a String for #{state.iso_code}"
refute_predicate state.example_city_zip, :empty?, "example_city_zip should not be empty for #{state.iso_code}"
end
end

Expand Down
Loading