Fix example_city and example_city_zip non-nil tests so they actually assert such#365
Open
larouxn wants to merge 1 commit intoShopify:mainfrom
Open
Fix example_city and example_city_zip non-nil tests so they actually assert such#365larouxn wants to merge 1 commit intoShopify:mainfrom
example_city and example_city_zip non-nil tests so they actually assert such#365larouxn wants to merge 1 commit intoShopify:mainfrom
Conversation
larouxn
force-pushed
the
fix_region_yml_tests
branch
2 times, most recently
from
c3cb644 to
e5806dd
Compare
larouxn
force-pushed
the
fix_region_yml_tests
branch
from
e5806dd to
1dfd184
Compare
larouxn
force-pushed
the
fix_region_yml_tests
branch
from
1dfd184 to
cb78b7e
Compare
larouxn
force-pushed
the
fix_region_yml_tests
branch
from
cb78b7e to
03875bf
Compare
larouxn
force-pushed
the
fix_region_yml_tests
branch
from
03875bf to
4734750
Compare
larouxn
force-pushed
the
fix_region_yml_tests
branch
from
4734750 to
30edc40
Compare
larouxn
force-pushed
the
fix_region_yml_tests
branch
2 times, most recently
from
2addc75 to
edaf797
Compare
The tests currently appear to not be testing anything as assert_predicate does not appear to accept a block. As such the following warning appears when running the tests: ```console /home/larouxn/src/github.com/larouxn/worldwide/test/worldwide/region_yml_consistency_test.rb:488: warning: the block passed to 'assert_predicate' defined at /home/larouxn/.gem/ruby/3.4.4/gems/minitest-5.25.5/lib/minitest/assertions.rb:391 may be ignored ```
larouxn
force-pushed
the
fix_region_yml_tests
branch
from
edaf797 to
e5f5f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Ensure the updated tests actually assert that all US states/territories (aside from UM) have an example city and zip. The tests currently appear to not be testing anything as
assert_predicatedoes not appear to accept a block re: docs and the following warning which appears when running the tests:/home/larouxn/src/github.com/larouxn/worldwide/test/worldwide/region_yml_consistency_test.rb:488: warning: the block passed to 'assert_predicate' defined at /home/larouxn/.gem/ruby/3.4.4/gems/minitest-5.25.5/lib/minitest/assertions.rb:391 may be ignoredWhat approach did you choose and why?
Broke down the assertions into one by one within a loop and added a skip for
UMas it's an outlier.What should reviewers focus on?
Are we okay with the method of skipping
UM?The impact of these changes
Tests actually assert what we want to assert.
Testing
With the updated tests but no
UMskip.With the updated test plus
UMskip.Checklist
Determined not necessary as it's a developer facing change, not user facing.